Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stonecrop] use new v-model API #114

Merged
merged 2 commits into from
Apr 18, 2024
Merged

[stonecrop] use new v-model API #114

merged 2 commits into from
Apr 18, 2024

Conversation

Alchez
Copy link
Collaborator

@Alchez Alchez commented Apr 18, 2024 •
edited
Loading

Closes #112.

Todos:

  • Figure out edge cases of v-model that have more complex setups or processing.
  • Figure out migration cases to move stonecrop components to a composable-style API

@Alchez Alchez requested a review from agritheory April 18, 2024 10:09
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for ./aform

Status Category Percentage Covered / Total
🔴 Lines 53.38% (🎯 70%) 599 / 1122
🔴 Statements 53.38% (🎯 70%) 599 / 1122
🔴 Functions 52.63% (🎯 70%) 20 / 38
🔴 Branches 67.39% (🎯 70%) 31 / 46
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
aform/src/components/AForm.vue 92.3% 80% 83.33% 92.3% 41-44, 65-66
aform/src/components/form/ACheckbox.vue 100% 100% 100% 100%
aform/src/components/form/ANumericInput.vue 100% 100% 100% 100%
Unchanged Files
aform/src/index.ts 0% 0% 0% 0% 1-27
aform/src/components/base/CollapseButton.vue 0% 0% 0% 0% 1-36
aform/src/components/form/AComboBox.vue 0% 0% 0% 0% 1-13
aform/src/components/form/ADate.vue 0% 0% 0% 0% 1-277
aform/src/components/form/ADropdown.vue 85.43% 89.47% 50% 85.43% 68-70, 77-78, 92-93, 99-103, 108-109, 114-117, 119-122, 124-127, 129-132
aform/src/components/form/AFieldset.vue 0% 0% 0% 0% 1-63
aform/src/components/form/ATextInput.vue 100% 80% 100% 100%
aform/src/directives/mask.ts 31.73% 28.57% 40% 31.73% 13-22, 28-34, 40-41, 47-60, 62-78, 83-103
Generated in workflow #124

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for ./atable

Status Category Percentage Covered / Total
🔴 Lines 68% (🎯 70%) 595 / 875
🔴 Statements 68% (🎯 70%) 595 / 875
🔴 Functions 56.52% (🎯 70%) 13 / 23
🔴 Branches 46.29% (🎯 70%) 25 / 54
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Unchanged Files
atable/src/index.ts 0% 0% 0% 0% 1-20
atable/src/components/ACell.vue 82.62% 38.09% 75% 82.62% 19-21, 59-65, 74-76, 79-81, 84-94, 110-114, 144-147, 165
atable/src/components/AExpansionRow.vue 0% 0% 0% 0% 1-88
atable/src/components/ARow.vue 65.51% 20% 25% 65.51% 6-12, 46-67, 72-73, 78-79, 82-88
atable/src/components/ATable.vue 67.61% 50% 33.33% 67.61% 101-140, 149-155, 159-179
atable/src/components/ATableHeader.vue 98.33% 28.57% 100% 98.33% 1
atable/src/components/ATableModal.vue 96% 100% 0% 96% 21-22
atable/src/components/index.ts 79.66% 84.61% 87.5% 79.66% 47-54, 61-62, 104-117
Generated in workflow #124

@Alchez
Copy link
Collaborator Author

Alchez commented Apr 18, 2024

@agritheory I've only updated the cases where the switch from the old way is easiest. There are still a few cases where the update is a bit more complex which we can look at together (for example, the v-model usage in aform uses a nested setup which as far as I can tell isn't a straightforward move).

Regarding the refactor to a composable style, we can also talk through some examples of what you're expecting.

@Alchez Alchez marked this pull request as ready for review April 18, 2024 14:39
agritheory
agritheory approved these changes Apr 18, 2024
View reviewed changes
Copy link
Owner

@agritheory agritheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked about, these dist diffs are really discouraging

@agritheory agritheory merged commit 9c2cafe into development Apr 18, 2024
4 of 6 checks passed
@Alchez Alchez deleted the feat-new-v-model branch April 19, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agritheory agritheory agritheory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[project] New preferred API for v-model
2 participants
@Alchez @agritheory